Be Careful with GIDs in Rails

Posted by julik 6 days ago

Comments

Comment by hopeless 22 hours ago

A bit of a bizarre post since to_sgid has existed forever to generate signed global ids. Global IDs are probably one the most powerful and underrated features of Rails but regular global ids are only supposed to be used internally (e.g. job params) and never sent to the client.

If there’s a gotcha it’s that _signed_ global ids are only signed, not encrypted, and very few people seem to know about the optimised method (globalid::Locator.locate_many) for loading a batch of global ids

Comment by yetanotherjosh 18 hours ago

I struggle to understand what this specifically has to do with rails or global IDs. In ANY framework or query system, if you are asking an LLM to produce IDs which you are then passing to a database for lookup, you need to understand those identifiers could be hallucinated or incorrect in surprising or malicious ways, and can lead to data leaks or exfiltration.

It's like writing an article about "the dangers of PostgreSQL" ... when generating SQL from an LLM. It has nothing to do with Postgres specifically, it's that you're generating queries to run in a trusted context from an untrustable origin.

Comment by otikik 20 hours ago

If you don't want invoice 22 to be shown by someone putting 22 on the url, you definetly need to enforce permissions on your app. The Global ID issue is tangential to that.

Comment by jsmith45 18 hours ago

Sure but the real concern of the article that if passed "gid://moneymaker/Invoice/22ecb3fd-5e25-462c-ad2b-cafed9435d16" the global id locator will effectively locate "gid://moneymaker/Invoice/22". Which is to say, that what is supposed to be a system-generated id which has no need for de-slugification, uses the same lookup method as is normally used for URLs which attempts to de-slugify.

Obviously, this means that first gid was bogus anyway, as it was trying to look up via the wrong key, but the fact that it doesn't fail, and will instead return the record with primary key "22" can certainly be surprising.

Comment by tyrellj 14 hours ago

The original comment is valid though, this has nothing to do with GIDs, standard /:id/ routes, and Model.find() can suffer the same issue. Probably because "22ecb3fd-5e25-462c-ad2b-cafed9435d16".to_i is still 22?

Comment by config_yml 21 hours ago

> GIDs are not checked for authorization when doing the lookup - they are meant to be generated above the authorization layer, and to be consumed above the authorization layer

Then the problem with this post boils down to applying the authorization layer in any tool call, just like you do in controllers. Seems obvious?

Comment by jeremy_k 19 hours ago

Agreed. Seems like the author tried to get fancy using GIDs with LLMs to cut down on the logic in their tool calls and opened a can of worms.

Comment by philipallstar 22 hours ago

This title is odd, given the actual identified problem seems to be LLMs writing code.

Comment by 18 hours ago

Comment by claudiug 21 hours ago

yeah, but if you say LLM is shit, and not rails... goodbye views :)

Comment by rco8786 20 hours ago

So....LLMs can hallucinate GIDs. I hope that everyone is aware of that.

Comment by moondowner 22 hours ago

Any popular Rails apps that use to_global_id?

Comment by rmosolgo 21 hours ago

Shopify: https://shopify.dev/docs/api/usage/gids#global-id-structure

Comment by hahahacorn 21 hours ago

Shopify https://shopify.dev/docs/api/usage/gids

Comment by kayodelycaon 21 hours ago

The built-in ActiveJob api uses them.

Comment by rco8786 20 hours ago

Almost any modern rails apps that have a job queue will use this at some point

Comment by axelthegerman 15 hours ago

Or more like "be careful with the power you give your LLMs"

Comment by usernamed7 21 hours ago

the AI hallucinated and somehow it's rails fault?

GID's are great - i think the issue is with how they leveraged rubyLLM for something they should inherently not be using LLMs for.

> Remember that GIDs were made for facilitating ActiveJob serialization - they are a system-level facility, not a product-level facility.

I think this is somewhat obvious given the signature like gid://awesome-app/Post/32; there is no scoping to the user or account so it should be treated like a global lookup. If you need scoping to a user/account you can build that.

Honestly I think this is a matter of the author using poor design decisions and over leveraging LLMs. But this is not the fault of Rails, it is working as expected.